lkml.org 
[lkml]   [2012]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] numa: don't check if node is NUMA_NO_NODE
On Mon, 03 Sep 2012 16:12:12 +0800
Wen Congyang <wency@cn.fujitsu.com> wrote:

> If we don't debug per_cpu maps, the cpu's node is stored in per_cpu variable
> numa_node. If node is NUMA_NO_NODE, it means the caller want to clear the
> cpu's node. So we should also call set_cpu_numa_node() in this case.

The changelog is missing important information.

What is the runtime effect of the patch? In other words, please fully
describe the runtime effects of the bug which the patch fixed.

Please always provide this information. It will help others decide
which kernel version(s) should be patched, and will help the
maintainers of other kernel trees (especially vendor trees) to work out
whether they should backport the fix into their kernels.

> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -97,8 +97,7 @@ void __cpuinit numa_set_node(int cpu, int node)
> #endif
> per_cpu(x86_cpu_to_node_map, cpu) = node;
>
> - if (node != NUMA_NO_NODE)
> - set_cpu_numa_node(cpu, node);
> + set_cpu_numa_node(cpu, node);
> }
>
> void __cpuinit numa_clear_node(int cpu)



\
 
 \ /
  Last update: 2012-09-05 02:02    [W:0.938 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site