Messages in this thread | | | Date | Tue, 4 Sep 2012 19:27:04 +0800 | From | Dong Aisheng <> | Subject | Re: [PATCH v5 3/4] regulator: anatop-regulator: convert to use syscon to access anatop register |
| |
On Tue, Sep 04, 2012 at 07:34:32PM +0800, Shawn Guo wrote: > On Tue, Sep 04, 2012 at 11:20:10AM +0800, Dong Aisheng wrote: > > + > > + anatop_np = of_get_parent(np); > > + if (!anatop_np) > > + return -ENODEV; > > + sreg->anatop = syscon_node_to_regmap(anatop_np); > > + if (IS_ERR(sreg->anatop)) > > + return PTR_ERR(sreg->anatop); > > + > With of_node_put moved out from syscon_node_to_regmap, shouldn't > we put anatop_np here then? > When i sent it out, i found i missed it... Should be more care...
Regards Dong Aisheng
| |