lkml.org 
[lkml]   [2012]   [Sep]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -v2 12/13] x86, mm: Use func pointer to table size calculation and mapping.
From
On Sun, Sep 2, 2012 at 10:46 AM, Yinghai Lu <yinghai@kernel.org> wrote:
> +static void __init with_all_ram_ranges(
> + void (*work_fn)(unsigned long, unsigned long, void *),
> + void *data)

> +static void __init size_work_fn(unsigned long start, unsigned long end, void *data)

> +static void __init mapping_work_fn(unsigned long start, unsigned long end,
> + void *data)

So I passionately hate the naming convention. How about something
similar to mm/pagewalk.c:

s/with_all_ram_ranges/walk_ram_ranges/g

s/size_work_fn/table_space_size/g

s/mapping_work_fn/map_memory/g


\
 
 \ /
  Last update: 2012-09-03 08:22    [W:0.138 / U:3.096 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site