Messages in this thread | | | Date | Mon, 3 Sep 2012 15:21:12 +0530 | From | Prabhakar Lad <> | Subject | Re: [PATCH] media: v4l2-ctrls: add control for test pattern |
| |
Hi Sylwester,
Thanks for the review.
On Monday 03 September 2012 02:55 PM, Sylwester Nawrocki wrote: > On 09/03/2012 11:16 AM, Prabhakar Lad wrote: >> diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c >> index 2d7bc15..ae709d1 100644 >> --- a/drivers/media/v4l2-core/v4l2-ctrls.c >> +++ b/drivers/media/v4l2-core/v4l2-ctrls.c >> @@ -430,6 +430,18 @@ const char * const *v4l2_ctrl_get_menu(u32 id) >> "Advanced Predictor", >> NULL, >> }; >> + static const char * const test_pattern[] = { >> + "Test Pattern Disabled", > > How about just "Disabled" ? > Ok.
Thanks and Regards, --Prabhakar Lad
>> + "Vertical Lines", >> + "Horizontal Lines", >> + "Diagonal Lines", >> + "Solid Black", >> + "Solid White", >> + "Solid Blue", >> + "Solid Red", >> + "Checker Board", >> + NULL, >> + }; > > -- > > Regards, > Sylwester >
| |