Messages in this thread | | | Date | Fri, 28 Sep 2012 21:53:11 -0400 (EDT) | From | Alan Stern <> | Subject | Re: Probable false positive in checkpatch |
| |
On Fri, 28 Sep 2012, Joe Perches wrote:
> On Fri, 2012-09-28 at 15:50 -0400, Alan Stern wrote: > > Here's what I just got from checkpatch: > > > > ERROR: space prohibited after that '-' (ctx:BxW) > > #22: FILE: drivers/usb/host/ehci-sched.c:1419: > > + start += (next - start + period - 1) & (- period); > > ^ > > This seems unlikely to be a real style violation. Or if it is, maybe > > it shouldn't be. After all, "(0 - period)" would be okay. > > 2c: I think the recommendation is proper and correct.
I just looked in CodingStyle, and sure enough, there it is in section 3.1. The complaint is hereby withdrawn.
Alan Stern
| |