lkml.org 
[lkml]   [2012]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 09/10] ARM: msm: Make proc_comm clock control into a platform driver
From
Hi Stephen,

Its good you started moving the msm to common clock framework.:)
I hope msm's codeaurora tree will also be moved to CCF soon. :)

On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> To move closer to the generic struct clock framework move the
> proc_comm based clock code to a platform driver. The data
> describing the struct clks still live in the devices-$ARCH file,
> but the clock initialization is done at driver binding time.
>
> Cc: Saravana Kannan <skannan@codeaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Reviewed-by: Pankaj Jangra<jangra.pankaj9@gmail.com>

> arch/arm/mach-msm/board-halibut.c | 2 +-
> arch/arm/mach-msm/board-msm7x30.c | 2 +-
> arch/arm/mach-msm/board-qsd8x50.c | 2 +-
> arch/arm/mach-msm/board-trout.c | 3 +--
> arch/arm/mach-msm/clock-pcom.c | 23 +++++++++++++++++++++--
> arch/arm/mach-msm/clock-pcom.h | 5 +++++
> arch/arm/mach-msm/clock.c | 2 +-
> arch/arm/mach-msm/clock.h | 3 +++
> arch/arm/mach-msm/devices-msm7x00.c | 12 ++++++++++--
> arch/arm/mach-msm/devices-msm7x30.c | 11 +++++++++--
> arch/arm/mach-msm/devices-qsd8x50.c | 11 +++++++++--
> arch/arm/mach-msm/devices.h | 15 +++------------
> arch/arm/mach-msm/include/mach/board.h | 5 -----
> 13 files changed, 65 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/mach-msm/board-halibut.c b/arch/arm/mach-msm/board-halibut.c
> index 6ce542e..3c8cfe4 100644
> --- a/arch/arm/mach-msm/board-halibut.c
> +++ b/arch/arm/mach-msm/board-halibut.c
> @@ -59,6 +59,7 @@ static struct platform_device smc91x_device = {
> };

> +
> +static int __devinit msm_clock_pcom_probe(struct platform_device *pdev)
> +{
> + struct pcom_clk_pdata *pdata = pdev->dev.platform_data;

Should'nt it be const struct?

> + msm_clock_init(pdata->lookup, pdata->num_lookups);
> + return 0;
> +}
> +
--
Pankaj Jangra


\
 
 \ /
  Last update: 2012-09-26 20:41    [W:0.158 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site