lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] Staging:bcm: fix coding style error in InterfaceIsr.c
On Tue, Sep 25, 2012 at 11:04:29AM +0600, Gorskin Ilya wrote:
> This is a patch to the InterfaceIsr.c file that
> fixes up a coding style issues found by the checkpatch.pl tool

I'm afraid all these need to be redone along the lines which I
explained in my other email.

>
> Signed-off-by: Ilya Gorskin <revent82@gmail.com>
> ---
> drivers/staging/bcm/InterfaceIsr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/bcm/InterfaceIsr.c b/drivers/staging/bcm/InterfaceIsr.c
> index 4f78451..0e68485 100644
> --- a/drivers/staging/bcm/InterfaceIsr.c
> +++ b/drivers/staging/bcm/InterfaceIsr.c
> @@ -120,7 +120,7 @@ static void read_int_callback(struct urb *urb/*, struct pt_regs *regs*/)
> urb->status = STATUS_SUCCESS ;
> break ;
> /*return;*/
> - default:
> + default:
> /*This is required to check what is the defaults
> * conditions when it occurs..*/
> BCM_DEBUG_PRINT(Adapter, DBG_TYPE_TX, NEXT_SEND,

Checkpatch is a tool that finds ugly code. You've silenced the
warning. The code still looks like dog vommit, but now checkpatch
doesn't find it. Don't do that.

regards,
dan carpenter



\
 
 \ /
  Last update: 2012-09-25 09:41    [W:0.060 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site