lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pagemap: fix wrong KPF_THP on slab pages
On Tue, 25 Sep 2012, Naoya Horiguchi wrote:

> KPF_THP can be set on non-huge compound pages like slab pages, because
> PageTransCompound only sees PG_head and PG_tail. Obviously this is a bug
> and breaks user space applications which look for thp via /proc/kpageflags.
> Currently thp is constructed only on anonymous pages, so this patch makes
> KPF_THP be set when both of PageAnon and PageTransCompound are true.
>
> Changelog in v2:
> - add a comment in code
>
> Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

Wouldn't PageTransCompound(page) && !PageHuge(page) && !PageSlab(page) be
better for a future extension of thp support?


\
 
 \ /
  Last update: 2012-09-26 03:01    [W:2.852 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site