lkml.org 
[lkml]   [2012]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.
From
Date
On Tue, 2012-09-25 at 19:45 +0800, Tang Chen wrote:


> Let's have an example here.
>
> sched_init_numa()
> {
> ...
> // A loop set sched_domains_numa_levels to level.-------------1
>
> // I set sched_domains_numa_levels to 0.
> sched_domains_numa_levels = 0;--------------------------------2

Ah, ok, so this 'idiot in a hurry' (aka. me) placed the hunk wrong and
thought it was at the start of the function.

> // A loop allocating memory for sched_domains_numa_masks[][]
> for (i = 0; i < level; i++) {
> ......
> // Allocate memory for sched_domains_numa_masks[i]----3
> ......
> }
> ......
>
> // I reset sched_domains_numa_levels to level.
> sched_domains_numa_levels = level;----------------------------4
> }

Yes this makes sense, it might be best to have this as a separate patch.


\
 
 \ /
  Last update: 2012-09-25 16:01    [W:0.060 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site