Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH v3 8/9] perf hists browser: Add option for runtime switching perf data file | Date | Tue, 25 Sep 2012 11:11:21 +0900 |
| |
On Mon, 24 Sep 2012 23:24:10 +0800, Feng Tang wrote: [snip] > + if (!check_perf_magic(magic)) { > + options[nr_options] = strdup(name); > + abs_path[nr_options++] = strdup(path);
Need to check return values.
> + } > + fclose(file); > + } > + closedir(pwd_dir); > + > + if (nr_options) { > + choice = ui__popup_menu(nr_options, options); > + if (choice < nr_options && choice >= 0) { > + input_name = strdup(abs_path[choice]);
Ditto. Plus it might leak previous input_name.
Thanks, Namhyung
> + ret = 0; > + } > + } > + > + free_popup_options(options, nr_options); > + free_popup_options(abs_path, nr_options); > + return ret; > +} > + > +
| |