lkml.org 
[lkml]   [2012]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 8/9] perf hists browser: Add option for runtime switching perf data file
Date
On Mon, 24 Sep 2012 23:24:10 +0800, Feng Tang wrote:
[snip]
> + if (!check_perf_magic(magic)) {
> + options[nr_options] = strdup(name);
> + abs_path[nr_options++] = strdup(path);

Need to check return values.


> + }
> + fclose(file);
> + }
> + closedir(pwd_dir);
> +
> + if (nr_options) {
> + choice = ui__popup_menu(nr_options, options);
> + if (choice < nr_options && choice >= 0) {
> + input_name = strdup(abs_path[choice]);

Ditto. Plus it might leak previous input_name.

Thanks,
Namhyung


> + ret = 0;
> + }
> + }
> +
> + free_popup_options(options, nr_options);
> + free_popup_options(abs_path, nr_options);
> + return ret;
> +}
> +
> +


\
 
 \ /
  Last update: 2012-09-25 04:41    [W:0.310 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site