lkml.org 
[lkml]   [2012]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] c/r: prctl: fix build error for no-MMU case
    On Mon, Sep 24, 2012 at 05:41:32PM -0400, Mark Salter wrote:
    > Commit 1ad75b9e1 added some address checking to prctl_set_mm()
    > used by checkpoint-restore. This causes a build error for no-MMU
    > systems:
    >
    > kernel/sys.c: In function 'prctl_set_mm':
    > kernel/sys.c:1868:34: error: 'mmap_min_addr' undeclared (first use in this function)
    >
    > The test for mmap_min_addr doesn't make a lot of sense for no-MMU
    > code as noted in commit 6e1415467. This patch defines mmap_min_addr
    > as 0UL in the no-MMU case so that the compiler will optimize away
    > tests for "addr < mmap_min_addr".
    >
    > Signed-off-by: Mark Salter <msalter@redhat.com>

    Thanks, Mark! I should add that this mmap_min_addr currently
    referenced in other parts of code only under CONFIG_MMU so this
    definition in header should not break anything.

    Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>


    \
     
     \ /
      Last update: 2012-09-25 00:41    [W:0.022 / U:33.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site