Messages in this thread | | | Date | Mon, 24 Sep 2012 21:04:51 +0200 | Subject | Re: [PATCH 3/6] dyndbg: add more info to -E2BIG log warning | From | Geert Uytterhoeven <> |
| |
On Mon, Sep 24, 2012 at 9:00 PM, Jason Baron <jbaron@redhat.com> wrote: >> - pr_warn("expected <%d bytes into control\n", USER_BUF_PAGE);
%u?
>> + pr_warn("expected <%d bytes into control, you wrote %d\n", >> + USER_BUF_PAGE, (int) len); > > The style here, I think, is generally to leave out the space, ie: (int)len.
Better, remove the cast and use "%zu" to properly format the size_t.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |