Messages in this thread | | | Date | Mon, 24 Sep 2012 19:28:32 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] x86, kprobes: Hide skip_singlestep forward declaration properly |
| |
(2012/09/20 18:40), Ingo Molnar wrote: > > * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: > >> (2012/09/20 18:25), Ingo Molnar wrote: >>> >>> * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: >>> >>>> (2012/09/19 22:46), Borislav Petkov wrote: >>>>> From: Borislav Petkov <borislav.petkov@amd.com> >>>>> >>>>> I get >>>>> >>>>> arch/x86/kernel/kprobes.c:544:23: warning: ‘skip_singlestep’ declared ‘static’ but never defined [-Wunused-function] >>>>> >>>>> on tip/auto-latest. >>>>> >>>>> Hide the forward declaration in the KPROBES_CAN_USE_FTRACE as it >>>>> is done in its callsites. >>>> >>>> Thank you for reporting and fixing :) >>> >>> Why is a forward declation needed, why isn't the function in the >>> proper spot in the file to begin with? >> >> There is no reason, ftrace-related things can also be moved on top. >> Borislav, could you move it? > > Could be moved into a separate file as well - we could have > arch/x86/kprobes/, with core.c, opt.c, ftrace.c and common.h in > it - possibly more in the future.
OK, I'll break it into those pieces :)
Thank you,
-- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |