Messages in this thread | | | Date | Sat, 22 Sep 2012 11:06:05 +0100 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 0/3] Introduce devm_clk_register() |
| |
On Tue, Sep 18, 2012 at 11:05:27PM -0700, Stephen Boyd wrote: > The first patch in this series fixes error checking in the wm831x clock > driver and is here to prevent context conflicts in the third patch. > I split it out in case it needed to merge sooner rather than later. > > The goal of this series is to add devm_clk_register() so I can use it in > some MSM clock code I'm sending out in the near future. The second > patch adds the API and the third patch moves over an existing user of > clk_unregister() to the devm API.
Can we guarantee that the clocks are unused when the module is removed? If we can't make that guarantee, then devm_* should not be used here, and instead there should be refcounting done in the clocks (that's what the __clk_get() and __clk_put() hooks are there for.)
| |