Messages in this thread | | | Date | Fri, 21 Sep 2012 07:05:27 -0600 | From | David Ahern <> | Subject | Re: [PATCH 1/4] perf tools: configure tmp path at build time |
| |
On 9/21/12 1:47 AM, Pekka Enberg wrote:
>> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c >> index e2e8c69..eb671d5 100644 >> --- a/tools/perf/util/symbol.c >> +++ b/tools/perf/util/symbol.c >> @@ -1051,7 +1051,7 @@ int dso__load(struct dso *dso, struct map *map, symbol_filter_t filter) >> >> dso->adjust_symbols = 0; >> >> - if (strncmp(dso->name, "/tmp/perf-", 10) == 0) { >> + if (strncmp(dso->name, PERF_TMP_DIR "/perf-", 10) == 0) { >> struct stat st;
And, with "/tmp" as a variable the 10 in the strncmp might not be right.
David
| |