lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pda_power: ac_draw used before set
On Wed, Sep 19, 2012 at 06:36:19PM +0100, Paul Parsons wrote:
> When I reboot my iPAQ hx4700 in its cradle, the battery will not begin
> to charge even though the AC supply is connected. Charging will start
> only after the PDA power driver is tickled by some other power event,
> such as reseating the iPAQ in its cradle or connecting the USB cable.
>
> The problem lies in pda_power_probe(), where ac_draw is used by the call
> to update_charger() before being set by the call to regulator_get().
>
> Moving the regulator_get() call to before the update_charger() call
> fixes the problem.
>
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> Cc: Philipp Zabel <philipp.zabel@gmail.com>
> ---

Great to see that someone is still using hx4700. :-)

Thanks for the patch, it is merged now!

Cheers,
Anton.

p.s.
The patch was mangled (word wrapped), but I fixed it up. Just fyi...


\
 
 \ /
  Last update: 2012-09-21 00:21    [W:0.091 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site