lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Fix bug in end absolute address in drivers/mtd/devices/slram.c
On Thu, 20 Sep 2012, Jiri Engelthaler wrote:

> Hello.
> I found a bug in parsing end absolute address in
> drivers/mtd/devices/slram.c. There is checking for startaddress <
> endaddress and endaddress subtracted by startaddress before check. The
> bug is there from commit 3afd522de8d8ec446efe957b86e4f63e3dd8ce9d Mon,
> 19 Jan 2009 01:24:21 +0000
>
> Here is the patch
>
> Signed-off-by: Jiri Engelthaler <engycz@gmail.com>
>
> --- linux-3.2.28/drivers/mtd/devices/slram.c 2012-08-19 19:15:38.000000000 +0200
> +++ linux-3.2.28.mod/drivers/mtd/devices/slram.c 2012-09-19
> 18:29:28.012740703 +0200
> @@ -266,7 +266,7 @@ static int parse_cmdline(char *devname,
>
> if (*(szlength) != '+') {
> devlength = simple_strtoul(szlength, &buffer, 0);
> - devlength = handle_unit(devlength, buffer) - devstart;
> + devlength = handle_unit(devlength, buffer);
> if (devlength < devstart)
> goto err_out;

... adding the suspects to CC so that they are aware of this.

--
Jiri Kosina
SUSE Labs



\
 
 \ /
  Last update: 2012-09-20 18:41    [W:0.034 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site