lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] perf tool: Add a global variable "const char *input_name"
Em Thu, Sep 20, 2012 at 10:19:39PM +0800, Feng Tang escreveu:
> Currently many perf ommands annotate/evlist/report/script/lock etc
> all support "-i" option to chose a specific perf data, and all
> of them create a local "input_name" to save the file name for
> that perf data.
>
> So adding a global variable could unify all those local ones, and
> it will also be useful for other codes which need to know the file name.

But I think the input_name should be passed as a parameter to whoever
needs it. Think about 'perf diff', for instance, it deals with two
perf.data files.

In general I think we should _remove_ more globals :-)

- Arnaldo


\
 
 \ /
  Last update: 2012-09-20 17:41    [W:1.772 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site