lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/4] perf header: Add struct perf_header_info
From
Date
2012-09-20 (목), 04:43 -0700, Arnaldo Carvalho de Melo:
> Em Thu, Sep 20, 2012 at 02:36:44PM +0900, Namhyung Kim escreveu:
> > From: Namhyung Kim <namhyung.kim@lge.com>
> >
> > The struct perf_header_info will preserve environment information at
> > the time of perf record. It can be accessed anytime after parsing a
> > perf.data file if needed.
>
> > +struct perf_header_info {
>
> I think it would be better named as 'perf_session_env' i.e. the
> environment (machine (name), hardware(nr_cpus, total_mem, etc) and
> OS(release, version) details) where a 'perf' 'session' took place.
>
> perf 'header info' look more like 'what is the version in the header?
> what about its endianity, and other 'header' details :-)

Okay, will rename and resend tomorrow!

/me always failed to make a good name :(

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-09-20 16:21    [from the cache]
©2003-2011 Jasper Spaans