lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] audit: Use a tracepoint for getname
cc'ing Jeff Layton who has recently done a lot of getname work and I
want to make sure he sees this.


On Wed, 19 Sep 2012 15:56:59 -0700
Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> Al, Eric,
>
> Was this considered before? Acceptable?
>
> - Arnaldo
>
> ---
>
> Instead of an explicit hook only for audit, use a tracepoint, so that
> other users that need to know about filenames can hook there just like
> audit.

> @@ -978,6 +986,9 @@ static int __init audit_init(void)
> else
> audit_sock->sk_sndtimeo = MAX_SCHEDULE_TIMEOUT;
>
> + if (register_trace_getname(audit_getname, NULL))
> + audit_panic("cannot register getname tracepoint");
> +
> skb_queue_head_init(&audit_skb_queue);
> skb_queue_head_init(&audit_skb_hold_queue);
> audit_initialized = AUDIT_INITIALIZED;

I think we need to just use panic instead of audit_panic. This early
at boot userspace would not have been able to tell the kernel that
audit_panic == panic nor would the box die later if userspace ask for
that functionality. Instead the box would run but audit would be
broken, which customers who want audit_panic == panic would be most
upset about.

Otherwise, its good to me.

-Eric


\
 
 \ /
  Last update: 2012-09-20 15:21    [W:0.042 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site