lkml.org 
[lkml]   [2012]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rtsx.c
Date
fixed some coccinelle warnings.
+ drivers/staging/rts_pstor/rtsx.c:397:16-19: ERROR: dev is NULL but dereferenced.
drivers/staging/rts_pstor/rtsx.c:447:16-19: ERROR: dev is NULL but dereferenced.
drivers/staging/rts_pstor/rtsx.c:358:16-19: ERROR: dev is NULL but dereferenced.

Signed-off-by: YAMANE Toshiaki <yamanetoshi@gmail.com>
---
drivers/staging/rts_pstor/rtsx.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c
index 213829e..afe9c2e 100644
--- a/drivers/staging/rts_pstor/rtsx.c
+++ b/drivers/staging/rts_pstor/rtsx.c
@@ -352,12 +352,8 @@ static int rtsx_suspend(struct pci_dev *pci, pm_message_t state)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;

- dev_info(&dev->pci->dev, "Ready to suspend\n");
-
- if (!dev) {
- dev_err(&dev->pci->dev, "Invalid memory\n");
+ if (!dev)
return 0;
- }

/* lock the device pointers */
mutex_lock(&(dev->dev_mutex));
@@ -391,12 +387,8 @@ static int rtsx_resume(struct pci_dev *pci)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;

- dev_info(&dev->pci->dev, "Ready to resume\n");
-
- if (!dev) {
- dev_err(&dev->pci->dev, "Invalid memory\n");
+ if (!dev)
return 0;
- }

chip = dev->chip;

@@ -441,12 +433,8 @@ static void rtsx_shutdown(struct pci_dev *pci)
struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci);
struct rtsx_chip *chip;

- dev_info(&dev->pci->dev, "Ready to shutdown\n");
-
- if (!dev) {
- dev_err(&dev->pci->dev, "Invalid memory\n");
+ if (!dev)
return;
- }

chip = dev->chip;

--
1.7.9.5


\
 
 \ /
  Last update: 2012-09-20 14:41    [W:0.028 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site