Messages in this thread | | | Subject | Re: [PATCH v2] USB: remove dbg() usage in USB networking drivers | From | Joe Perches <> | Date | Thu, 20 Sep 2012 03:07:13 -0700 |
| |
On Wed, 2012-09-19 at 20:46 +0100, Greg Kroah-Hartman wrote: > The dbg() USB macro is so old, it predates me. The USB networking drivers are > the last hold-out using this macro, and we want to get rid of it, so replace > the usage of it with the proper netdev_dbg() or dev_dbg() (depending on the > context) calls.
OK, one more bit of trivia
> diff --git a/drivers/net/usb/net1080.c b/drivers/net/usb/net1080.c [] > @@ -422,8 +419,9 @@ static int net1080_rx_fixup(struct usbnet *dev, struct sk_buff *skb) > if (!(skb->len & 0x01)) { > #ifdef DEBUG > struct net_device *net = dev->net; > - dbg("rx framesize %d range %d..%d mtu %d", skb->len, > - net->hard_header_len, dev->hard_mtu, net->mtu); > + netdev_dbg(dev->net, "rx framesize %d range %d..%d mtu %d\n", > + skb->len, net->hard_header_len, dev->hard_mtu, > + net->mtu); > #endif
maybe netdev_dbg(net, ...
or remove the odd #ifdef DEBUG surround used to guard the otherwise unused net variable and use:
netdev_dbg(dev->net, "rx framesize %d range %d..%d mtu %d\n", skb->len, dev->net->hard_header_len, dev->hard_mtu, dev->net->mtu);
| |