Messages in this thread | | | Date | Sun, 02 Sep 2012 12:29:44 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH RFC 1/1] kvm: Use vcpu_id as pivot instead of last boosted vcpu in PLE handler |
| |
On 09/02/2012 06:12 AM, Gleb Natapov wrote: > On Thu, Aug 30, 2012 at 12:51:01AM +0530, Raghavendra K T wrote: >> The idea of starting from next vcpu (source of yield_to + 1) seem to work >> well for overcomitted guest rather than using last boosted vcpu. We can also >> remove per VM variable with this approach. >> >> Iteration for eligible candidate after this patch starts from vcpu source+1 >> and ends at source-1 (after wrapping) >> >> Thanks Nikunj for his quick verification of the patch. >> >> Please let me know if this patch is interesting and makes sense. >> > This last_boosted_vcpu thing caused us trouble during attempt to > implement vcpu destruction. It is good to see it removed from this POV.
I like this implementation. It should achieve pretty much the same as my old code, but without the downsides and without having to keep the same amount of global state.
-- All rights reversed
| |