Messages in this thread Patch in this message | | | Date | Sun, 2 Sep 2012 10:33:20 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: regression 3.5->3.6: usb keyboard not working anymore |
| |
On Thu, 30 Aug 2012, Andres Freund wrote:
> > With a quick grep I just discovered that a new driver for this (or > > similar?) keyboards has been added. I have *not* compiled this in though: > > +# CONFIG_HID_LENOVO_TPKBD is not set > > > > Is the new, unconditional, entry in the hid_have_special_driver struct the > > problem? > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index 8e3a6b2..f695680 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -1544,6 +1544,7 @@ static const struct hid_device_id > > hid_have_special_driver[] = { > > { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M610X) }, > > { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, > > USB_DEVICE_ID_LABTEC_WIRELESS_KEYBOARD) }, > > { HID_USB_DEVICE(USB_VENDOR_ID_LCPOWER, USB_DEVICE_ID_LCPOWER_LC1000 ) > > }, + { HID_USB_DEVICE(USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_TPKBD) > > }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER) > > }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER) > > }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER_2) > > }, > > > > Other entries seem to be protected via things like: > > #if IS_ENABLED(CONFIG_HID_LOGITECH_DJ) > > > > I have somewhat obsoleted my original line of thought in this email, but > > hell. Will try this and send a patch if it works. > Works. > > Could somebody integrate the attached patch?
Hmm ... you are right, that this is a regression in a sense that if you have a working kernel, do oldconfig with the default settings, and then you lose your keyboard.
I don't like the aproach you used in your patch though ... we are not doing this for other devices either. For those, which were previously supported by core driver and then a new driver with enhanced support was spinned of, we rather make different default config option.
So how about rather something like
drivers/hid/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index a451cdb..d5b98d9 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -289,6 +289,7 @@ config HID_LENOVO_TPKBD depends on USB_HID select NEW_LEDS select LEDS_CLASS + default HID_GENERIC ---help--- Support for the Lenovo ThinkPad USB Keyboard with TrackPoint. That will fix the oldconfig issue and will not polute the hid_have_special_driver[] by a rather ugly ifdef. Thanks,
-- Jiri Kosina SUSE Labs
| |