Messages in this thread | | | Date | Mon, 3 Sep 2012 09:53:36 +0930 | From | Jonathan Woithe <> | Subject | Re: [PATCH 4/5] platform: x86: remove acpi_bus_generate_proc_event |
| |
On Mon, Sep 03, 2012 at 02:03:31AM +0200, Davidlohr Bueso wrote: > Calling this function no longer makes sense as /proc/acpi/event > is being removed. > > Signed-off-by: Davidlohr Bueso <dave@gnu.org> > : > drivers/platform/x86/fujitsu-laptop.c | 4 ---- > : > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index c4c1a54..2fac1c5 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -773,8 +773,6 @@ static void acpi_fujitsu_notify(struct acpi_device *device, u32 event) > else > set_lcd_level(newb); > } > - acpi_bus_generate_proc_event(fujitsu->dev, > - ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS, 0); > keycode = KEY_BRIGHTNESSUP; > } else if (oldb > newb) { > if (disable_brightness_adjust != 1) { > @@ -783,8 +781,6 @@ static void acpi_fujitsu_notify(struct acpi_device *device, u32 event) > else > set_lcd_level(newb); > } > - acpi_bus_generate_proc_event(fujitsu->dev, > - ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS, 0); > keycode = KEY_BRIGHTNESSDOWN; > } > break;
Presumedly the intention here is for these events to be delivered via the input layer after the removal of /proc/acpi/event (as is done later in the above function).
If that's the case, then: Acked-by: Jonathan Woithe <jwoithe@just42.net>
Regards jonathan
| |