lkml.org 
[lkml]   [2012]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf report: Add missing perf_hpp__init for pipe-mode
    Commit-ID:  60e5c706b3ea56f87afc2a4a3096118d28f9cc24
    Gitweb: http://git.kernel.org/tip/60e5c706b3ea56f87afc2a4a3096118d28f9cc24
    Author: Namhyung Kim <namhyung.kim@lge.com>
    AuthorDate: Thu, 13 Sep 2012 13:14:30 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Mon, 17 Sep 2012 13:11:33 -0300

    perf report: Add missing perf_hpp__init for pipe-mode

    The perf_hpp__init() function was only called from setup_browser() so
    that the pipe-mode missed the initialization thus didn't respond to
    related options. Fix it.

    Reported-by: Robert Richter <robert.richter@amd.com>
    Tested-by: Robert Richter <robert.richter@amd.com>
    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Robert Richter <robert.richter@amd.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-tip-commits@vger.kernel.org
    Link: http://lkml.kernel.org/r/87txv28spl.fsf_-_@sejong.aot.lge.com
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/builtin-report.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
    index b6696dd..1da243d 100644
    --- a/tools/perf/builtin-report.c
    +++ b/tools/perf/builtin-report.c
    @@ -689,8 +689,10 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)

    if (strcmp(report.input_name, "-") != 0)
    setup_browser(true);
    - else
    + else {
    use_browser = 0;
    + perf_hpp__init(false, false);
    + }

    setup_sorting(report_usage, options);


    \
     
     \ /
      Last update: 2012-09-19 18:41    [W:0.028 / U:4.036 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site