Messages in this thread Patch in this message | | | From | Alan Cox <> | Subject | [RFC PATCH 1/2] binfmt_elf: Fix corner case kfree of uninitialized data | Date | Wed, 19 Sep 2012 15:44:35 +0100 |
| |
Could do with double checking...
From: Alan Cox <alan@linux.intel.com>
If elf_core_dump is called and fill_note_info fails in the kmalloc then it returns 0 but has not yet initialised all the needed fields. As a result we do a kfree(randomness) after correctly skipping the thread data.
Signed-off-by: Alan Cox <alan@linux.intel.com> ---
fs/binfmt_elf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 1b4efbc..bf6d82b 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1492,8 +1492,10 @@ static int fill_note_info(struct elfhdr *elf, int phdrs, info->thread = NULL; psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL); - if (psinfo == NULL) + if (psinfo == NULL) { + info->psinfo.data = NULL; /* So we don't free this wrongly */ return 0; + } fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);
| |