Messages in this thread | | | Date | Wed, 19 Sep 2012 13:42:58 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] tools lib traceevent: Handle alloc_arg failure |
| |
* Namhyung Kim <namhyung@kernel.org> wrote:
> + if (!left) { > + do_warning("%s(%d): not enough memory!", __func__, __LINE__); > + goto out_free;
> + if (!right) { > + do_warning("%s(%d): not enough memory!", __func__, __LINE__); > + goto out_free; > + }
> + if (!left) { > + do_warning("%s(%d): not enough memory!", __func__, __LINE__); > + goto out_free; > + }
> + if (!left) { > + do_warning("%s(%d): not enough memory!", __func__, __LINE__); > + goto out_free; > + }
> + if (!right) { > + do_warning("%s(%d): not enough memory!", __func__, __LINE__); > + goto out_free; > + }
> + if (!left) { > + do_warning("%s(%d): not enough memory!", __func__, __LINE__); > + goto out_free; > + }
These repetitive patterns are seriously uglifying the code and are crying out loud for a out_war_free label:
if (!left) goto out_warn_free;
(The function here seems to be rather large as well, making it a possible candidate for shrinkage/splitup.)
Thanks,
Ingo
| |