lkml.org 
[lkml]   [2012]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] i2c: OMAP fix driver initialization message
From
Date
Hi Benoit,

On Sep 18, 2012, at 10:24 PM, a0919096 wrote:

> Hi Panto,
>
> That patch is good, but a similar one was already posted by Florian.
> https://patchwork.kernel.org/patch/1392671/
>
> Checking the email thread it seems that Wolfram pulled it.
>
> Regards,
> Benoit
>

Great. One less thing to look after :)

Regards

-- Pantelis

> On 9/19/2012 11:07 AM, Pantelis Antoniou wrote:
>> The message spit out when the i2c-omap driver load is printing
>> the platform device's id as a bus number. However when booting
>> from OF id is -1, which is not so nice.
>>
>> Fix it by printing the adapter number.
>>
>> [ 0.210467] omap_i2c 44e0b000.i2c: bus -1 rev2.4.0 at 400 kHz
>> vs
>> [ 0.210467] omap_i2c 44e0b000.i2c: bus 0 rev2.4.0 at 400 kHz
>>
>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>> ---
>> drivers/i2c/busses/i2c-omap.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
>> index f722478..87bb705 100644
>> --- a/drivers/i2c/busses/i2c-omap.c
>> +++ b/drivers/i2c/busses/i2c-omap.c
>> @@ -1178,9 +1178,6 @@ omap_i2c_probe(struct platform_device *pdev)
>> goto err_unuse_clocks;
>> }
>>
>> - dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", pdev->id,
>> - dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
>> -
>> adap = &dev->adapter;
>> i2c_set_adapdata(adap, dev);
>> adap->owner = THIS_MODULE;
>> @@ -1204,6 +1201,9 @@ omap_i2c_probe(struct platform_device *pdev)
>> if (IS_ERR(pinctrl))
>> dev_warn(dev->dev, "pins are not configured from the driver\n");
>>
>> + dev_info(dev->dev, "bus %d rev%d.%d.%d at %d kHz\n", adap->nr,
>> + dev->dtrev, dev->rev >> 4, dev->rev & 0xf, dev->speed);
>> +
>> pm_runtime_mark_last_busy(dev->dev);
>> pm_runtime_put_autosuspend(dev->dev);
>>
>>
>



\
 
 \ /
  Last update: 2012-09-19 12:41    [W:0.053 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site