Messages in this thread Patch in this message | | | Date | Wed, 19 Sep 2012 09:41:13 +0800 | From | Fengguang Wu <> | Subject | [PATCH] mfd: use IRQF_ONESHOT for max8925 |
| |
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT.
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> ---
Please take the patch only if it's a positive warning. Thanks!
drivers/mfd/max8925-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/drivers/mfd/max8925-core.c 2012-09-18 08:22:36.381180459 +0800 +++ linux/drivers/mfd/max8925-core.c 2012-09-19 09:37:52.471984440 +0800 @@ -547,7 +547,7 @@ static int max8925_irq_init(struct max89 goto tsc_irq; } - ret = request_threaded_irq(irq, NULL, max8925_irq, flags, + ret = request_threaded_irq(irq, NULL, max8925_irq, flags | IRQF_ONESHOT, "max8925", chip); if (ret) { dev_err(chip->dev, "Failed to request core IRQ: %d\n", ret); @@ -565,7 +565,7 @@ tsc_irq: chip->tsc_irq = pdata->tsc_irq; ret = request_threaded_irq(chip->tsc_irq, NULL, max8925_tsc_irq, - flags, "max8925-tsc", chip); + flags | IRQF_ONESHOT, "max8925-tsc", chip); if (ret) { dev_err(chip->dev, "Failed to request TSC IRQ: %d\n", ret); chip->tsc_irq = 0;
| |