lkml.org 
[lkml]   [2012]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] vfs: dcache: fix deadlock in tree traversal
On Tue, Sep 18, 2012 at 9:27 AM, Miklos Szeredi <miklos@szeredi.hu> wrote:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>>
>> HOWEVER. Why introduce that new DCACHE_KILLED flag at all? Wouldn't it
>> be much better to just check whether the dentry is hashed instead of
>> introducing a new flag for this case? Couldn't we just check for
>> "d_unhashed()"?
>
> Not good, because an unhashed dentry can stay around and that would mean
> that we'd need to restart the walk until the last ref to the dentry is
> dropped (which can be an arbitrary long time).

Ok, fair enough.

I'll apply your second patch as obviously fixing one issue, and wait
for Al to hopefully come up with something nicer for the first one.

Linus


\
 
 \ /
  Last update: 2012-09-18 21:01    [W:0.056 / U:5.756 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site