Messages in this thread | | | From | "Bounine, Alexandre" <> | Subject | RE: [PATCH] drivers/rapidio/devices/tsi721.c: fix error return code | Date | Tue, 18 Sep 2012 12:27:55 +0000 |
| |
On Monday, Sep.17, at 2012 4:14 AM Peter Senna Tschudin wrote: > > Convert a nonnegative error return code to a negative one, as returned > elsewhere in the function. > ... skip ... > > Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> > --- > drivers/rapidio/devices/tsi721.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/rapidio/devices/tsi721.c > b/drivers/rapidio/devices/tsi721.c > index 1974359..78dff6f 100644 > --- a/drivers/rapidio/devices/tsi721.c > +++ b/drivers/rapidio/devices/tsi721.c > @@ -2316,7 +2316,8 @@ static int __devinit tsi721_probe(struct pci_dev > *pdev, > > /* Configure DMA attributes. */ > if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) { > - if (pci_set_dma_mask(pdev, DMA_BIT_MASK(32))) { > + err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32)); > + if (err) { > dev_info(&pdev->dev, "Unable to set DMA mask\n"); > goto err_unmap_bars; > } > -- > 1.7.11.4
Acked-by: Alexandre Bounine <alexandre.bounine@idt.com>
| |