lkml.org 
[lkml]   [2012]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3 v2] perf tool: give user better message if precise is not supported

* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, 2012-09-14 at 22:11 +0200, Ingo Molnar wrote:
> > return -EPERF_CPU_PRECISE_EV_NOTSUPP;
>
> I just don't like having to enumerate all possible fails, I'm
> too lazy. Can't we be smarter about that? Could we do a
> {reason}x{bit-offset} like thing?
>
> Where we limit reason to a few simple things like:
>
> invalid
> out-of-range
> not-supported
>
> and have the bit-offset indicate the field we're having the particular
> problem with?
>
> Then all we need is a smart way to generate and map the bit-offsets
> without too much manual labour.

Putting the 'where' into a separate field would do that, and
thus we could generate and report such structured errors as well
- but nevertheless there will always be special/individual
errors as well that won't fit into such a scheme, for which we
should include a 'boring' errno range as well ...

I.e. a {where},{what} s32 pair of fields - if 'where' is zero
then 'what' is the enumerated errno value I suggested, if it's
nonzero then it's the 'where' indication you suggested.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-09-17 09:41    [W:0.075 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site