Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH repost] virtio: don't crash when device is buggy | Date | Mon, 17 Sep 2012 13:57:17 +0930 |
| |
"Michael S. Tsirkin" <mst@redhat.com> writes:
> Because of a sanity check in virtio_dev_remove, a buggy device can crash > kernel. And in case of rproc it's userspace so it's not a good idea. > We are unloading a driver so how bad can it be? > Be less aggressive in handling this error: if it's a driver bug, > warning once should be enough. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> > > -- > > 3.6 material?
I have already applied, this, but it's not for stable, since it's a "theoretical bugfix". That check has been in there forever and noone AFAIK has actually struck it.
Cheers, Rusty.
| |