lkml.org 
[lkml]   [2012]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/2] module: wait when loading a module which is currently initializing.
    Date
    Lucas De Marchi <lucas.demarchi@profusion.mobi> writes:
    >> - if (find_module(mod->name)) {
    >> + if ((old = find_module(mod->name)) != NULL) {
    >> + if (old->state == MODULE_STATE_COMING) {
    >> + /* Wait in case it fails to load. */
    >> + mutex_unlock(&module_mutex);
    >> + err = wait_event_interruptible(module_wq,
    >> + finished_loading(mod->name));
    >> + if (err)
    >> + goto free_arch_cleanup;
    >> + goto again;
    >
    > I wonder if we should indeed retry in case the module failed to load
    > or if we should just skip straight to returning the error code. We
    > don't have the return code for the failed load, but maybe we can
    > fabricate one here.
    >
    > Thoughts?

    Could have different cmdline parameters, or other randomness like
    out-of-memory. I think this is safest.

    Cheers,
    Rusty.


    \
     
     \ /
      Last update: 2012-09-17 14:21    [W:0.032 / U:119.000 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site