lkml.org 
[lkml]   [2012]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] PCI: Annotate pci_fixup_irqs with __devinit
    On Fri, Sep 14, 2012 at 03:35:31PM -0700, Greg Kroah-Hartman wrote:
    > On Fri, Sep 14, 2012 at 02:53:11PM -0600, Bjorn Helgaas wrote:
    > > +cc Greg KH
    > >
    > > On Fri, Sep 14, 2012 at 2:44 PM, Thierry Reding
    > > <thierry.reding@avionic-design.de> wrote:
    > > > In order to keep pci_fixup_irqs() around after init (e.g. for hotplug),
    > > > mark it __devinit instead of __init. This requires the same change for
    > > > the implementation of the pcibios_update_irq() function on all
    > > > architectures.
    > > >
    > > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
    > > > ---
    > > > Note: Ideally these annotations should go away completely in order to
    > > > be independent of the HOTPLUG symbol. However, there is work underway
    > > > to get rid of HOTPLUG altogether, so I've kept the __devinit for now.
    >
    > No, just take away the __init marking completly. For 3.7,
    > CONFIG_HOTPLUG will always be enabled, making it be the same thing.
    > That way this saves me the time and energy from deleting the __devinit
    > markings when I get to that point in the patch series :)

    Done. I'll give other people some time to comment before sending the
    updated series.

    Thierry
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-09-15 10:41    [W:0.026 / U:32.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site