Messages in this thread | | | Date | Fri, 14 Sep 2012 13:55:55 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] xattr: prevent NULL ptr deref warnings in __simple_xattr_set |
| |
On Fri, Sep 14, 2012 at 01:54:34PM -0700, Tejun Heo wrote: > On Fri, Sep 14, 2012 at 09:35:54PM +0200, Sasha Levin wrote: > > Prevent warnings generated by smatch due to unchecked dereference of > > 'new_xattr' in __simple_xattr_set(). > > Isn't this an actual bug w/ or w/o smatch? Remove request (NULL > @value) w/o XATTR_REPLACE for an non-existent node would end up > calling list_add() on NULL, right? If so, please collapse these two > patches and mention the actual bug instead of smatch warning.
And can somebody please make that function less confusing? - restructuring / commenting whatever. It's doing something simple. It's not supposed to be this confusing.
Thanks.
-- tejun
| |