lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3 v2] perf tool: give user better message if precise is not supported
Em Fri, Sep 14, 2012 at 05:43:42AM -0600, David Ahern escreveu:
> On 9/14/12 5:36 AM, Ingo Molnar wrote:

> >Well, then that is useful information we *lost*, and that situation
> >needs to be improved on the ABI side: an expanded error code present
> >in the event structure, copied back to user-space on errors, or so.

> Understood and there have been suggestions on how to definitely state
> what the kernel side did not like. I like Peter's last suggestion --
> something along the lines of clearing attr on a failure except the
> offending setting.

I think ws need to use a new bit, attr.clear_opsup_on_error,
that we would set, older kernels would return an error cause they don't
support this new feature, the tool would then clear it and work as
today, giving a vague message, cause that is all it can do.

We can't just clean the unsupported bits because then older tools would
get completely confused when trying to use the current fallback
mechanism, where, for instance, for sample_id_all, we just reset it in
the tooling side, ask again the kernel and it works.

Older tools not setting the clear_supported_bits_on_error would get the
current behaviour.

- Arnaldo


\
 
 \ /
  Last update: 2012-09-14 20:41    [from the cache]
©2003-2011 Jasper Spaans