lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] uprobes: Do not leak UTASK_BP_HIT if find_active_uprobe() fails
    (additional note to simplify the review)

    On 09/14, Oleg Nesterov wrote:
    >
    > Note
    > that we do this unconditionally, see the next patch(es).

    IOW, we could move it under "if (!uprobe)" branch, but we do not.

    This is mostly needed for 2/5, which in turn is needed for 3/5.
    If can_skip_sstep() succeeds we need to reset utask->state too.

    ALternatively we could start with 4/5, but this is the "separate"
    change (and it is not bug-fix) which needs your review/ack.

    Oleg.



    \
     
     \ /
      Last update: 2012-09-14 20:21    [W:0.028 / U:0.760 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site