lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 16/24] xen: clear IRQ_NOAUTOEN and IRQ_NOREQUEST
    On 14/09/12 12:13, Stefano Stabellini wrote:
    > Reset the IRQ_NOAUTOEN and IRQ_NOREQUEST flags that are enabled by
    > default on ARM. If IRQ_NOAUTOEN is set, __setup_irq doesn't call
    > irq_startup, that is responsible for calling irq_unmask at startup time.
    > As a result event channels remain masked.
    >
    > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
    > Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    > ---
    > drivers/xen/events.c | 1 +
    > 1 files changed, 1 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/xen/events.c b/drivers/xen/events.c
    > index 5ecb596..8ffb7b7 100644
    > --- a/drivers/xen/events.c
    > +++ b/drivers/xen/events.c
    > @@ -836,6 +836,7 @@ int bind_evtchn_to_irq(unsigned int evtchn)
    > struct irq_info *info = info_for_irq(irq);
    > WARN_ON(info == NULL || info->type != IRQT_EVTCHN);
    > }
    > + irq_clear_status_flags(irq, IRQ_NOREQUEST|IRQ_NOAUTOEN);

    This one just sent a shiver down my spine. Are you doing this for a PPI?

    M.
    --
    Jazz is not dead. It just smells funny...



    \
     
     \ /
      Last update: 2012-09-14 16:41    [W:0.022 / U:2.660 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site