lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 06/17] Documentation: Define the MOP500 Audio Machine Driver Device Tree bindings
    On Tue, Sep 11, 2012 at 11:06:00AM +0200, Ola Lilja wrote:
    > On 09/10/2012 06:44 PM, Lee Jones wrote:
    >
    > > Ola poke.
    > >
    > > On Fri, Aug 24, 2012 at 03:01:42PM +0100, Lee Jones wrote:
    > >> Here we add the required documentation for the new Device Tree
    > >> bindings pertaining to the MOP500 Audio Machine driver.
    > >>
    > >> CC: alsa-devel@alsa-project.org
    > >> Signed-off-by: Lee Jones <lee.jones@linaro.org>
    > >> ---
    > >> .../devicetree/bindings/sound/ux500-mop500.txt | 39 ++++++++++++++++++++
    > >> 1 file changed, 39 insertions(+)
    > >> create mode 100644 Documentation/devicetree/bindings/sound/ux500-mop500.txt
    > >>
    > >> diff --git a/Documentation/devicetree/bindings/sound/ux500-mop500.txt b/Documentation/devicetree/bindings/sound/ux500-mop500.txt
    > >> new file mode 100644
    > >> index 0000000..48e071c
    > >> --- /dev/null
    > >> +++ b/Documentation/devicetree/bindings/sound/ux500-mop500.txt
    > >> @@ -0,0 +1,39 @@
    > >> +* MOP500 Audio Machine Driver
    > >> +
    > >> +This node is responsible for linking together all ux500 Audio Driver components.
    > >> +
    > >> +Required properties:
    > >> + - compatible : "stericsson,snd-soc-mop500"
    > >> +
    > >> +Non-standard properties:
    > >> + - stericsson,cpu-dai : Phandle to the CPU-side DAI
    > >> + - stericsson,audio-codec : Phandle to the Audio CODEC
    > >> + - stericsson,card-name : Over-ride default card name
    > >> +
    > >> +Example:
    > >> +
    > >> + sound {
    > >> + compatible = "stericsson,snd-soc-mop500";
    > >> +
    > >> + stericsson,cpu-dai = <&msp1 &msp3>;
    > >> + stericsson,audio-codec = <&codec>;
    > >> + };
    > >> +
    > >> + msp1: msp@80124000 {
    > >> + compatible = "stericsson,ux500-msp-i2s";
    > >> + reg = <0x80124000 0x1000>;
    > >> + interrupts = <0 62 0x4>;
    > >> + v-ape-supply = <&db8500_vape_reg>;
    >
    >
    > I'm no DT-expert, but why are you adding MSP-stuff in the machine-driver? They
    > are also added in the next patch.

    This is a documentation file. Duplication is not important, as it's only there
    for reference.

    > >> + };
    > >> +
    > >> + msp3: msp@80125000 {
    > >> + compatible = "stericsson,ux500-msp-i2s";
    > >> + reg = <0x80125000 0x1000>;
    > >> + interrupts = <0 62 0x4>;
    > >> + v-ape-supply = <&db8500_vape_reg>;
    > >> + };
    > >> +
    > >> + codec: ab8500-codec {
    > >> + compatible = "stericsson,ab8500-codec";
    > >> + stericsson,earpeice-cmv = <950>; /* Units in mV. */
    >
    >
    > Only four voltages are allowed here. Maybe enumerate them in the comment?

    This isn't the ab8500-codec documentation. For valid earpiece values please
    see the documentation in patch "Documentation: Add the AB8500 CODEC device
    to the MFD AB8500 doc"

    Apart from these comments does the patch looks okay?

    --
    Lee Jones
    Linaro ST-Ericsson Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-09-14 13:41    [W:0.030 / U:1.740 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site