lkml.org 
[lkml]   [2012]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 5/5] MFD: ti_tscadc: add suspend/resume functionality
Date
On Fri, Sep 14, 2012 at 10:39:20, Venu Byravarasu wrote:
> > -----Original Message-----
> > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> > owner@vger.kernel.org] On Behalf Of Patil, Rachna
> > Sent: Friday, September 14, 2012 10:29 AM
> > To: Lars-Peter Clausen
> > Cc: linux-kernel@vger.kernel.org; linux-input@vger.kernel.org; linux-
> > iio@vger.kernel.org; Samuel Ortiz; Dmitry Torokhov; Dmitry Torokhov;
> > Jonathan Cameron
> > Subject: RE: [PATCH v3 5/5] MFD: ti_tscadc: add suspend/resume
> > functionality
> >
> > On Thu, Sep 13, 2012 at 18:31:35, Lars-Peter Clausen wrote:
> > > On 09/13/2012 12:40 PM, Patil, Rachna wrote:
> > > > This patch adds support for suspend/resume of TSC/ADC MFDevice.
> > > >
> > > > Signed-off-by: Patil, Rachna <rachna@ti.com>
> > > > ---
> > > > Changes in v2:
> > > > Added this patch newly in this patch series.
> > > >
> > > > Changes in v3:
> > > > No changes.
> > > >
> > > > drivers/iio/adc/ti_adc.c | 32
> > ++++++++++++++++++++++++++++++++
> > > > drivers/input/touchscreen/ti_tsc.c | 33
> > +++++++++++++++++++++++++++++++++
> > > > drivers/mfd/ti_tscadc.c | 33
> > ++++++++++++++++++++++++++++++++-
> > > > include/linux/mfd/ti_tscadc.h | 3 +++
> > > > 4 files changed, 100 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/drivers/iio/adc/ti_adc.c b/drivers/iio/adc/ti_adc.c
> > > > index 56f8af2..69f19f0 100644
> > > > --- a/drivers/iio/adc/ti_adc.c
> > > > +++ b/drivers/iio/adc/ti_adc.c
> > > > @@ -207,6 +207,36 @@ static int __devexit tiadc_remove(struct
> > platform_device *pdev)
> > > > return 0;
> > > > }
> > > >
> > > [...]
> > > > static struct platform_driver tiadc_driver = {
> > > > .driver = {
> > > > .name = "tiadc",
> > > > @@ -214,6 +244,8 @@ static struct platform_driver tiadc_driver = {
> > > > },
> > > > .probe = tiadc_probe,
> > > > .remove = __devexit_p(tiadc_remove),
> > > > + .suspend = adc_suspend,
> > > > + .resume = adc_resume,
> > > > };
> > > >
> > >
> > >
> > > Using the suspend/resume callbacks is deprecated, please use
> > dev_pm_ops.
> > > Same comment applies to the other two drivers.
> >
> > Ok. I will make changes in all the 3 driver to use dev_pm_ops instead
> > of suspend/resume callbacks.
>
> Probably you might need to protect suspend/resumes with CONFIG_PM.

Yes, I will add that as well.

Regards,
Rachna



\
 
 \ /
  Last update: 2012-09-14 08:01    [W:0.897 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site