Messages in this thread | | | Date | Fri, 14 Sep 2012 09:33:48 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 14/19] ARM: ux500: Apply tc3589x's GPIO/IRQ properties to HREF's DT |
| |
On Mon, Sep 10, 2012 at 05:58:41AM -0700, Linus Walleij wrote: > On Fri, Sep 7, 2012 at 1:14 PM, Lee Jones <lee.jones@linaro.org> wrote: > > > This patch ensures the tc3589x and tc3598x-gpio devices are > > rightfully given interrupt controller status. We also describe > > the tc3598x-gpio GPIO expander in full and specify it as a GPIO > > controller. Finally we reference that the external MMC slot's > > Card Detection GPIO on the HREF is located on the tc3598x-gpio > > expander. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > This should come after the enablement patches instead of > before them, right? (Or be merged into them even as > we've discussed.)
No, it needs to come before, or else the legacy values will be used which aren't correct.
> Apart from that it looks good, > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Yours, > Linus Walleij
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |