Messages in this thread | | | Date | Thu, 13 Sep 2012 21:43:16 +0200 | Subject | Re: [RE-RESEND][PATCH] audit: replace defines with C stubs | From | Geert Uytterhoeven <> |
| |
On Tue, Aug 7, 2012 at 2:40 AM, Kees Cook <keescook@chromium.org> wrote: > This replaces the #defines used when CONFIG_AUDIT or CONFIG_AUDIT_SYSCALLS > are disabled so we get type checking during those builds. > > Suggested-by: Andrew Morton <akpm@linux-foundation.org> > Signed-off-by: Kees Cook <keescook@chromium.org>
JFYI, the change
-#define audit_syscall_entry(ta,a,b,c,d,e) do { ; } while (0) +static inline void audit_syscall_entry(int arch, int major, unsigned long a0, + unsigned long a1, unsigned long a2, + unsigned long a3) +{ }
uncovers a bug on OpenRISC.
Before,
audit_syscall_entry(audit_arch(), regs->gpr[11], regs->gpr[3], regs->gpr[4], regs->gpr[5], regs->gpr[6]);
just expanded to nothing if CONFIG_AUDITSYSCALL was not set. Now, it fails to compile with:
arch/openrisc/kernel/ptrace.c:190:2: error: implicit declaration of function 'audit_arch' http://kisskb.ellerman.id.au/kisskb/buildresult/7191698/
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |