| Date | Thu, 13 Sep 2012 20:43:12 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 07/24] Staging: ipack/devices/ipoctal: Store isr masks in ipoctal_channel |
| |
On Wed, Sep 12, 2012 at 02:55:29PM +0200, Samuel Iglesias Gonsalvez wrote: > From: Jens Taprogge <jens.taprogge@taprogge.org> > > This way interrupt handling becomes independent of the channel number. > > Signed-off-by: Jens Taprogge <jens.taprogge@taprogge.org> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> > --- > @@ -213,7 +206,7 @@ static int ipoctal_irq_handler(void *arg) > } > > /* RX data */ > - if (isr_rx_rdy && (sr & SR_RX_READY)) { > + if ((isr && channel->isr_rx_rdy_mask) && (sr & SR_RX_READY)) { ^^ Bitwise AND intended here I think.
> value = ioread8(&channel->regs->r.rhr); > flag = TTY_NORMAL; > > @@ -244,7 +237,7 @@ static int ipoctal_irq_handler(void *arg) > } > > /* TX of each character */ > - if (isr_tx_rdy && (sr & SR_TX_READY)) { > + if ((isr & channel->isr_tx_rdy_mask) && (sr & SR_TX_READY)) {
regards, dan carpenter
|