Messages in this thread |  | | | Date | Thu, 13 Sep 2012 17:52:59 +0200 | | From | Oleg Nesterov <> | | Subject | Re: [PATCH 2/2] coredump: add a new elf note with siginfo fields of the signal |
| |
forgot to mention...
On 09/13, Oleg Nesterov wrote: > > Not sure this is right. I think fill_siginfo_note() should either do > memcpy() and let userspace to decode this (raw) info, or this layout > should be unified with copy_siginfo_to_user().
And note that we simply do not know what this siginfo contains if si_code < 0. Again, please look at copy_siginfo_to_user().
> Note also that we do not expose the upper bits of si_code to user-space, > probably coredump should do the same, I dunno.
If it was sent by kernel, I meant.
Oleg.
|  |