Messages in this thread | | | Date | Thu, 13 Sep 2012 13:51:31 +0100 | From | Alan Cox <> | Subject | Re: [RFC] tty: Add get- ioctls to fetch tty status |
| |
> +static int pty_get_lock(struct tty_struct *tty, int __user *arg) > +{ > + int locked = test_bit(TTY_PTY_LOCK, &tty->flags); > + if (put_user(locked, arg)) > + return -EFAULT;
Now explain exactly how this doesn't race with another thread chanigng the lock setting ?
The other comment I have is that it might be better put these in now there are sysfs patches for the tty layer bouncing about to provide the needed infrastructure ?
Alan
| |