lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 15/46] NFSv3: Ensure that do_proc_get_root() reports errors correctly
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.0-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Trond Myklebust <Trond.Myklebust@netapp.com>

    commit 086600430493e04b802bee6e5b3ce0458e4eb77f upstream.

    If the rpc call to NFS3PROC_FSINFO fails, then we need to report that
    error so that the mount fails. Otherwise we can end up with a
    superblock with completely unusable values for block sizes, maxfilesize,
    etc.

    Reported-by: Yuanming Chen <hikvision_linux@163.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/nfs/nfs3proc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfs/nfs3proc.c
    +++ b/fs/nfs/nfs3proc.c
    @@ -68,7 +68,7 @@ do_proc_get_root(struct rpc_clnt *client
    nfs_fattr_init(info->fattr);
    status = rpc_call_sync(client, &msg, 0);
    dprintk("%s: reply fsinfo: %d\n", __func__, status);
    - if (!(info->fattr->valid & NFS_ATTR_FATTR)) {
    + if (status == 0 && !(info->fattr->valid & NFS_ATTR_FATTR)) {
    msg.rpc_proc = &nfs3_procedures[NFS3PROC_GETATTR];
    msg.rpc_resp = info->fattr;
    status = rpc_call_sync(client, &msg, 0);



    \
     
     \ /
      Last update: 2012-09-13 02:41    [W:4.226 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site