Messages in this thread | | | Date | Wed, 12 Sep 2012 16:53:54 -0700 (PDT) | From | Hugh Dickins <> | Subject | Re: + mm-mmapc-replace-find_vma_prepare-with-clearer-find_vma_links.patch added to -mm tree |
| |
On Wed, 12 Sep 2012, David Rientjes wrote: > On Wed, 12 Sep 2012, Hugh Dickins wrote: > > > that we can't fix it all up to use > > > uninitialized_var() so this is handled the proper way? > > > > I do prefer to avoid it when we can, some reasons given below. > > It's easily silenced with __maybe_unused.
I'm not necessarily against __maybe_unused, but I am surprised that it should have an effect here: I think of that as a tool for a different job, and would be misleading in this context.
> > Given David's preference for no warning, mine for no uninitialized_var, > > and Linus's for renaming BUG() to I_AM_A_MORON() to discourage its use > > in the first place: copy_vma() seems a prime candidate for returning > > failure to mremap instead of crashing the system. > > > > Signed-off-by: Hugh Dickins <hughd@google.com> > > Tested-by: David Rientjes <rientjes@google.com>
Thanks!
Hugh
| |