lkml.org 
[lkml]   [2012]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:perf/core] perf hists: Introduce perf_hpp for hist period printing
On 09.09.12 01:54:39, tip-bot for Namhyung Kim wrote:
> Commit-ID: ea251d51d2c7d7233790123227f787c477f567f5
> Gitweb: http://git.kernel.org/tip/ea251d51d2c7d7233790123227f787c477f567f5
> Author: Namhyung Kim <namhyung.kim@lge.com>
> AuthorDate: Mon, 3 Sep 2012 11:53:06 +0900
> Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
> CommitDate: Sat, 8 Sep 2012 13:19:44 -0300
>
> perf hists: Introduce perf_hpp for hist period printing
>
> Current hist print functions are messy because it has to consider many
> of command line options and the code doing that is scattered around to
> places. So when someone wants to add an option to manipulate the hist
> output it'd very easy to miss to update all of them in sync. And things
> getting worse as more options/features are added continuously.
>
> So I'd like to refactor them using hpp formats and move common code to
> ui/hist.c in order to make it easy to maintain and to add new features.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Link: http://lkml.kernel.org/r/1346640790-17197-2-git-send-email-namhyung@kernel.org
> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/Makefile | 2 +
> tools/perf/builtin-diff.c | 1 +
> tools/perf/ui/hist.c | 340 ++++++++++++++++++++++++++++++++++++++++++++
> tools/perf/ui/setup.c | 8 +-
> tools/perf/ui/stdio/hist.c | 238 ++++++-------------------------
> tools/perf/util/hist.h | 37 +++++
> 6 files changed, 426 insertions(+), 200 deletions(-)

This patch breaks perf-record/report that the number of samples can't
be shown in pipe mode:

# perf record -e cycles -aq sleep 1 ; perf report -n --sort comm,dso | sed '/%/q;d' ; \
perf record -e cycles -aq sleep 1 | perf report -n --sort comm,dso | sed '/%/q;d'
99.86% 11804 swapper [kernel.kallsyms]
91.57% swapper [kernel.kallsyms]
^^^^^^
number of samples missing
Moving and changing the code at the same time make the patch
unreviewable. So no clue that's the problem here.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center



\
 
 \ /
  Last update: 2012-09-12 20:01    [from the cache]
©2003-2011 Jasper Spaans